Changeset 2076

Show
Ignore:
Timestamp:
03/08/12 14:49:56 (9 years ago)
Author:
jwoithe
Message:

isohandlermanager: whitespace cleanup around changes from r2074 and add an explanatory comment. As per the comments, the change prevents getPacket() being called prior to the housekeeping data being properly reset. When these were only reset at the end of the enable() method this was observed. This change may make restarts more reliable on certain devices, which occurs (for example) when jackd is switched out of freewheeling mode.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/libffado/src/libieee1394/IsoHandlerManager.cpp

    r2074 r2076  
    17661766    raw1394_set_userdata(m_handle, static_cast<void *>(this)); 
    17671767 
     1768    // Reset housekeeping data before preparing and starting the handler.  
     1769    // If only done afterwards, the transmit handler could be called before 
     1770    // these have been reset, leading to problems in getPacket(). 
    17681771#ifdef DEBUG 
    17691772    m_min_ahead = 7999; 
    17701773#endif 
    1771  
    17721774    m_packets = 0; 
     1775    m_last_cycle = -1; 
    17731776 
    17741777    // indicate that the first iterate() still has to occur. 
    17751778    m_last_now = 0xFFFFFFFF; 
    17761779    m_last_packet_handled_at = 0xFFFFFFFF; 
    1777  
    1778     m_last_cycle = -1; 
    1779  
    17801780 
    17811781    // prepare the handler, allocate the resources