Changeset 2501

Show
Ignore:
Timestamp:
05/01/14 01:00:16 (10 years ago)
Author:
jwoithe
Message:

saffire: according to a post by Phil on the ffado-devel list, the new version 2.0 firmware for the pro24 has been tested by users and confirmed to work for audio. Therefore remove the warning. There may still be some issues with MIDI, but that is a separate consideration.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/libffado/src/dice/focusrite/saffire_pro24.cpp

    r2437 r2501  
    428428        getEAP()->readRegBlock(Dice::EAP::eRT_Application, SAFFIRE_PRO24_REGISTER_APP_VERSION, version, 1*sizeof(fb_quadlet_t)); 
    429429        // On August 2013, Focusrite released a new firmware. 
    430         //  version numbering 2.0 (0x00020000) seems common to all Saffire Dice EAP devices 
    431         // FIXME: the following original comment is ambiguous: 0x00010004 and 0x00010008 stands  
    432         //   for a firmware version not for a device identity 
    433         // 0x00010004 is a pro24, 0x00010008 is the pro24dsp 
    434         if (version[0] != 0x00010004 && version[0] != 0x00010008) { 
    435             if (version[0] != 0x00020000) { 
    436               debugError("This is a Focusrite Saffire Pro24 but not the right firmware. Better stop here before something goes wrong.\n"); 
    437               debugError("This device has firmware 0x%x while we only know about versions 0x%x and 0x%x.\n", version[0], 0x10004, 0x10008); 
    438               return false; 
    439             } 
    440             // Warn about the new firmware 
    441             else { 
    442               debugWarning("This is a Focusrite Saffire Pro24 with new 2.0 firmware. Be aware it was not yet tested under FFADO\n"); 
    443             } 
     430        // Version numbering 2.0 (0x00020000) seems common to all Saffire  
     431        // Dice EAP devices. 
     432        // Note: 0x00010004 and 0x00010008 stands for a firmware version  
     433        // not for a device identity.  0x00010004 is a pro24, 0x00010008  
     434        // is the pro24dsp. 
     435        if (version[0] != 0x00010004 && version[0] != 0x00010008 && version[0] != 0x00020000) { 
     436            debugError("This is a Focusrite Saffire Pro24 but not the right firmware. Better stop here before something goes wrong.\n"); 
     437            debugError("This device has firmware 0x%x while we only know about versions 0x%x, 0x%x and 0x%x.\n", version[0], 0x10004, 0x10008, 0x00020000); 
     438            return false; 
    444439        } 
     440 
    445441        // FIXME: What is the purpose of the following commented lines at this point ? 
    446442        //getEAP()->readRegBlock(Dice::EAP::eRT_Command, 0x00, tmp, 2*sizeof(fb_quadlet_t)); // DEBUG