Show
Ignore:
Timestamp:
01/20/08 03:48:13 (16 years ago)
Author:
wagi
Message:

BeBoB::SubunitAudio::createFunctionBlock:

It is no use to add a dummy FunctionBlockProcessing? because
then the function type is not set in FunctionBlockProcessing?.
When we try to discover the plugs attached to this function block
it will fail. It's better just to skip them.

This fixes bug #15.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/libffado/src/bebob/bebob_avdevice_subunit.cpp

    r864 r865  
    277277        case ExtendedSubunitInfoCmd::ePT_DynamicRangeCompression: 
    278278        default: 
    279             fb = new FunctionBlockProcessing( *this, 
    280                                               data.m_functionBlockId, 
    281                                               purpose, 
    282                                               data.m_noOfInputPlugs, 
    283                                               data.m_noOfOutputPlugs, 
    284                                               (int)getDebugLevel() ); 
    285             debugWarning( "Dummy function block processing created. " 
    286                           "Implementation is missing\n" )
     279            /* It is no use to add a dummy FunctionBlockProcessing because 
     280               then the function type is not set in FunctionBlockProcessing.  
     281               When we try to discover the plugs attached to this function block 
     282               it will fail. It's better just to skip them. */ 
     283            debugWarning( "Found a processing subfunction (type %d) which is not supported. " 
     284                          "It will be ignored.\n", 
     285                          data.m_functionBlockType); 
     286            return true
    287287        } 
    288288    } 
     
    290290    case ExtendedSubunitInfoCmd::eFBT_AudioSubunitCodec: 
    291291    { 
    292         fb = new FunctionBlockCodec( *this, 
    293                                      data.m_functionBlockId, 
    294                                      purpose, 
    295                                      data.m_noOfInputPlugs, 
    296                                      data.m_noOfOutputPlugs, 
    297                                      (int)getDebugLevel() ); 
    298         debugWarning( "Dummy function block codec created. " 
    299                       "Implementation is missing\n" )
     292            /* It is no use to add a dummy FunctionBlockProcessing because 
     293               then the function type is not set in FunctionBlockProcessing.  
     294               When we try to discover the plugs attached to this function block 
     295               it will fail. It's better just to skip them. */ 
     296            debugWarning( "Found a codec subfunction (type %d) which is not supported. " 
     297                          "It will be ignored.\n", 
     298                          data.m_functionBlockType); 
     299            return true
    300300    } 
    301301    break;