Ticket #207 (closed bug: fixed)

Opened 12 years ago

Last modified 11 years ago

Repeated defines in Amdtp{Receive,Transmit}StreamProcessors

Reported by: adi Assigned to:
Priority: trivial Milestone: FFADO 2.0
Component: Version: FFADO 2.0-rc1 (1.999.40)
Keywords: Cc:
The device the bug applies to:

Description

Hi!

r1524 implements the same macro (HAS_LABEL) two times, once for AmdtpTransmit? and once for AmdtpReceive?.

This violates the "don't repeat yourself" design principle. (http://en.wikipedia.org/wiki/DRY)

The attached patch fixes it.

Attachments

amdtp-DRY.patch (4.7 kB) - added by adi on 03/26/09 14:51:53.

Change History

03/26/09 14:51:53 changed by adi

  • attachment amdtp-DRY.patch added.

05/17/09 04:33:28 changed by ppalmers

  • status changed from new to closed.
  • resolution set to fixed.

(In [1556]) fixes #207