width of Audiofire ffado-mixer should be resizable

SVN Diff of my changes.

The mixer window is expanded horizontally due to the large number of "Pad" buttons across the page on the Input tab. In addition, the Output Strips are all too big to fit in a single window.

I have changed the audiofire_strip.ui and audiofire.py to force the widgets to reasonably small values and to force the dynamic "Pad" buttons to be smaller too.

Please can a developer review and submit if acceptable.

Thanks,

Euan.

Screen shot of proposed change

I tested the patch on rev 1882 and it works exactly as I hoped. Thank you, Euan.

I suggest that a developer reviews it and submits it.

Can you guys check to see whether r1885 fixes things?

Otherwise I will try to add horizontal scrollbars. But I don't know whether these should affect the whole mixer, one tab (ie. one sub-mix) or just the inputs on each tab, so that playback and output are always visible.

Strange problem for me: I know Qt and python and why some of the layout-problems where there. Only I can't really test it as I don't have a profire:-) But I am working on tricking my ffado-mixer into believing I am having a profire...

ffado-mixer in this version r1885 does not open the mixer window, it stops after displaying the following log messages:

08:11:58 dbus: connecting to: Updated on /org/ffado/Control/DeviceManager (server: org.ffado.Control)
08:11:58 panelmanager: PanelManager::updatePanels()audiofire.py", line 257
08:11:58 panelmanager: going to add 0014860a5b6be484
08:11:58 panelmanager: Adding device 0: 0014860a5b6be484
08:11:58 panelmanager:  Found (0014860a5b6be484, 1486, AF9) Echo Digital Audio AudioFirePre8
08:11:58 registration: version/GUID combo already registered
08:11:59 audiofire: Init AudioFire mixer window
08:11:59 audiofire: Building mixer
08:12:00 audiofire: strip

Launching ffado-mixer in a terminal shows that the problem comes from QToolButton (was QPushButton previously):

$ ffado-mixer
08:11:58 dbus             DEBUG    connecting to: Updated on /org/ffado/Control/DeviceManager (server: org.ffado.Control)
08:11:58 panelmanager     DEBUG    PanelManager::updatePanels()
08:11:58 panelmanager     DEBUG    going to add 0014860a5b6be484
08:11:58 panelmanager     DEBUG    Adding device 0: 0014860a5b6be484
08:11:58 panelmanager     DEBUG     Found (0014860a5b6be484, 1486, AF9) Echo Digital Audio AudioFirePre8
08:11:58 registration     DEBUG    version/GUID combo already registered
08:11:59 audiofire        DEBUG    Init AudioFire mixer window
08:11:59 audiofire        DEBUG    Building mixer
08:12:00 audiofire        DEBUG    strip
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/ffado/panelmanager.py", line 349, in updatePanels
    mixerwidget.buildMixer()
  File "/usr/lib/python2.6/site-packages/ffado/mixer/audiofire.py", line 257, in buildMixer
    btn = QToolButton( grpInput )
NameError: global name 'QToolButton' is not defined

I replaced QToolButton by QPushButton in audiofire.py, line 257, and it worked!

I tested it with a single Audiofire Pre8, but also by chaining two of them. In this last case, ffado-mixer shows two tabs (I attach a screen capture). Adding horizontal scrollbars does not seem useful, at least for a screen that has a width of 1280px. The only point is that I cannot identify which box corresponds to each tab. It would be nice to show the IDs of the boxes.

May be the button "Identify Device" in tab "Settings" plays this role, but I see nothing when I push this button, except in the log which displays the message:

audiofire: trigger /Identify

Capture of ffado-mixer, r1885 plus correction of QToolButton, two chained devices

The advantage of the QToolButton is that this needs less space at the side of the text. So it gives smaller channel-strips.

I will add the correct include for the QToolButton this evening.

I don't have (or know) the hardware, but could it be that when you click the "identify" button, some lights on the device start to blink? So that you can identify it?

Unfortunately, there is no blinking light that could help identify the device.

It could be useful to see in the "Settings" tab for each box, an information similar to what is shown by ffado-test ListDevices , for instance: port, node and GUID.

This looks good. Thanks.

Arnold's final round of fixes for this issue seem to have been committed in r1887, which included the include fix noted in comment 5. It would therefore appear that this issue is resolved so I'll close the ticket.