Ticket #82 (closed enhancement: fixed)

Opened 13 years ago

Last modified 13 years ago

Fix a swathe of warnings

Reported by: laptop006 Assigned to:
Priority: trivial Milestone: FFADO 2.0
Component: Version:
Keywords: Cc:
The device the bug applies to:

Description

This is a small patch against r961 to clear a load of compiler warnings, mainly in two classes: - Signed/unsigned conversions - char arrays not being defined as const (all except for one in the motu code)

And it also clears a deprecated feature warning in dbus.

This should pretty much be a no-op, but please make sure I haven't done anything really stupid.

Thanks, Julien

Attachments

libffado-warnings-fix.patch (7.7 kB) - added by laptop006 on 03/19/08 05:23:51.
Patch
libffado-fixed-hunk.patch (0.7 kB) - added by laptop006 on 03/19/08 18:28:25.
Changed the last hunk to do the unsigned cast at compare time (after the tests for being negative)

Change History

03/19/08 05:23:51 changed by laptop006

  • attachment libffado-warnings-fix.patch added.

Patch

03/19/08 05:55:56 changed by ppalmers

  • status changed from new to closed.
  • resolution set to fixed.

Applied, except for one chunk.

Thanks for the patch.

03/19/08 18:28:25 changed by laptop006

  • attachment libffado-fixed-hunk.patch added.

Changed the last hunk to do the unsigned cast at compare time (after the tests for being negative)

03/19/08 18:29:06 changed by laptop006

  • status changed from closed to reopened.
  • resolution deleted.

Attached a patch to replace that last hunk in a more proper way.

03/20/08 01:58:18 changed by ppalmers

  • status changed from reopened to closed.
  • resolution set to fixed.

applied